doc: update cryptographic feature ADR #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Testing
p-offtermatt
reviewed
Nov 6, 2023
| @@ -8,6 +8,7 @@ title: Cryptographic verification of equivocation evidence | |||
| * 5/1/2023: First draft | |||
| * 7/23/2023: Add light client attacks handling | |||
| * 9/6/2023: Add double signing attacks handling | |||
| * 11/3/2023: Update limitations to handle amnesia attacks | |||
There was a problem hiding this comment.
Suggested change
| * 11/3/2023: Update limitations to handle amnesia attacks | |
| * 11/3/2023: Update limitations to clarify amnesia attacks are ignored |
This might be better at expressing what was changed in the adr? I didn't get the original changelog line
insumity
reviewed
Nov 6, 2023
docs/docs/adrs/adr-005-cryptographic-equivocation-verification.md
Outdated
Show resolved
Hide resolved
insumity
approved these changes
Nov 6, 2023
Co-authored-by: insumity <[email protected]>
mpoke
added a commit
that referenced
this pull request
Nov 30, 2023
update ADR Co-authored-by: Marius Poke <[email protected]>
MSalopek
pushed a commit
that referenced
this pull request
Dec 1, 2023
update ADR Co-authored-by: Marius Poke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
docs:prefix in the PR titleReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
docs:prefix in the PR titlemake build-docs)